Fix Cannot find module 'pnpapi'
#349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
louisscruz
force-pushed
the
lcruz/rescue-pnpapi-require
branch
from
e5eebfc
to
003f602
Compare
Codecov Report
@@ Coverage Diff @@
## main #349 +/- ##
==========================================
- Coverage 95.14% 95.03% -0.12%
==========================================
Files 39 39
Lines 1628 1630 +2
==========================================
Hits 1549 1549
- Misses 79 81 +2
Continue to review full report at Codecov.
|
louisscruz
force-pushed
the
lcruz/rescue-pnpapi-require
branch
from
08137b3
to
104ef09
Compare
louisscruz
force-pushed
the
lcruz/rescue-pnpapi-require
branch
from
104ef09
to
d06e3a8
Compare
|
One thing this fails to take into account is the issuer of a given request. Having looked around a little more, I now see that the superior solution of #301 already exists. Closing in favor of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #263, there are some scenarios in which
pnpapiis not currently resolvable (e.g.Cannot find module 'pnpapi'). This happens when usingjestto execute tests that make use ofwebpack. Here is an example stack trace, and here is a repo for reproduction.It's odd that
pnpapiis not resolvable when the Yarn documentation mentions that it should be resolvable ifprocess.versions.pnpis set.I've tried various other ways of loading upActually, it does work if you resort topnpapibased on @arcanis' comment here without any luck. For some reason,require('module').pnpApiPathisundefined.require("module").findPnpApi(process.cwd());! I previously thought I'd tried that, but must have gotten something wrong when trying.