Fix Promise issues where callback was being called twice

[appden]

This supersedes PR #5 by cherry-picking the commit by @koistya (resolving merge conflict) and then adding another commit where another .catch(callback).then(...) was causing a callback to be called twice, thus making Webpack throw an exception from inside the async module.

[jsf-clabot]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ appden
❌ koistya

[codecov]

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #15   +/-   ##
=======================================
  Coverage   91.33%   91.33%           
=======================================
  Files           2        2           
  Lines         254      254           
  Branches       67       67           
=======================================
  Hits          232      232           
  Misses         22       22

Impacted Files	Coverage Δ
lib/loadLoader.js	64% <100%> (ø)	⬆️
lib/LoaderRunner.js	94.32% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9385bda...25f15cb. Read the comment docs.

[sokra]

@koistya could you sign the CLA?

[CPatchane]

Hi here,

For some weird reasons, I am getting this error by using webpack 4.4.1 (with mini-css-extract-plugin v0.4.0).
I use cozy-scripts with yarn link to try building my application, the branch with the webpack 4 usage is here.
I am wondering if it is related to this issue or not but I hope it will help:

create-cozy-app/packages/cozy-scripts/node_modules/loader-runner/lib/LoaderRunner.js:114
			throw e;
			^

Error: Callback was already called.
    at throwError (create-cozy-app/packages/cozy-scripts/node_modules/neo-async/async.js:14:11)
    at create-cozy-app/packages/cozy-scripts/node_modules/neo-async/async.js:2760:7
    at Compilation.processModuleDependencies (create-cozy-app/packages/cozy-scripts/node_modules/webpack/lib/Compilation.js:427:4)
    at afterBuild (create-cozy-app/packages/cozy-scripts/node_modules/webpack/lib/Compilation.js:552:16)
    at _this.buildModule.err (create-cozy-app/packages/cozy-scripts/node_modules/webpack/lib/Compilation.js:598:11)
    at callback (create-cozy-app/packages/cozy-scripts/node_modules/webpack/lib/Compilation.js:349:35)
    at module.build.error (create-cozy-app/packages/cozy-scripts/node_modules/webpack/lib/Compilation.js:385:12)
    at handleParseError (create-cozy-app/packages/cozy-scripts/node_modules/webpack/lib/NormalModule.js:366:12)
    at doBuild.err (create-cozy-app/packages/cozy-scripts/node_modules/webpack/lib/NormalModule.js:396:5)
    at runLoaders (create-cozy-app/packages/cozy-scripts/node_modules/webpack/lib/NormalModule.js:272:12)
    at create-cozy-app/packages/cozy-scripts/node_modules/loader-runner/lib/LoaderRunner.js:370:3
    at iterateNormalLoaders (create-cozy-app/packages/cozy-scripts/node_modules/loader-runner/lib/LoaderRunner.js:211:10)
    at iterateNormalLoaders (create-cozy-app/packages/cozy-scripts/node_modules/loader-runner/lib/LoaderRunner.js:218:10)
    at create-cozy-app/packages/cozy-scripts/node_modules/loader-runner/lib/LoaderRunner.js:233:3
    at context.callback (create-cozy-app/packages/cozy-scripts/node_modules/loader-runner/lib/LoaderRunner.js:111:13)
    at cozy-collect/node_modules/babel-loader/lib/index.js:169:14
    at cozy-collect/node_modules/babel-loader/lib/fs-cache.js:127:9
    at cozy-collect/node_modules/graceful-fs/graceful-fs.js:43:10
    at create-cozy-app/packages/cozy-scripts/node_modules/graceful-fs/graceful-fs.js:43:10
    at FSReqWrap.oncomplete (fs.js:135:15)

[appden]

@sokra @koistya I just realized this was never merged. It's still an issue.

[appden]

Bumping this. I submitted it over a year ago and it's still an issue. 😞

[sokra]

CLA is still not signed

[sokra]

Change looks good

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@9385bda). Click here to learn what that means.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##             master      #15   +/-   ##
=========================================
  Coverage          ?   93.15%           
=========================================
  Files             ?        3           
  Lines             ?      263           
  Branches          ?       67           
=========================================
  Hits              ?      245           
  Misses            ?       18           
  Partials          ?        0

Impacted Files	Coverage Δ
lib/LoaderRunner.js	94.39% <100%> (ø)
lib/loadLoader.js	80.76% <50%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9385bda...25f15cb. Read the comment docs.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@9385bda). Click here to learn what that means.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##             master      #15   +/-   ##
=========================================
  Coverage          ?   93.15%           
=========================================
  Files             ?        3           
  Lines             ?      263           
  Branches          ?       67           
=========================================
  Hits              ?      245           
  Misses            ?       18           
  Partials          ?        0

Impacted Files	Coverage Δ
lib/LoaderRunner.js	94.39% <100%> (ø)
lib/loadLoader.js	80.76% <50%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9385bda...25f15cb. Read the comment docs.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@9385bda). Click here to learn what that means.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##             master      #15   +/-   ##
=========================================
  Coverage          ?   93.15%           
=========================================
  Files             ?        3           
  Lines             ?      263           
  Branches          ?       67           
=========================================
  Hits              ?      245           
  Misses            ?       18           
  Partials          ?        0

Impacted Files	Coverage Δ
lib/LoaderRunner.js	94.39% <100%> (ø)
lib/loadLoader.js	80.76% <50%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9385bda...25f15cb. Read the comment docs.