-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Promise issues where callback was being called twice #15
Conversation
|
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
=======================================
Coverage 91.33% 91.33%
=======================================
Files 2 2
Lines 254 254
Branches 67 67
=======================================
Hits 232 232
Misses 22 22
Continue to review full report at Codecov.
|
@koistya could you sign the CLA? |
Hi here, For some weird reasons, I am getting this error by using webpack 4.4.1 (with mini-css-extract-plugin v0.4.0).
|
Bumping this. I submitted it over a year ago and it's still an issue. 😞 |
CLA is still not signed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
=========================================
Coverage ? 93.15%
=========================================
Files ? 3
Lines ? 263
Branches ? 67
=========================================
Hits ? 245
Misses ? 18
Partials ? 0
Continue to review full report at Codecov.
|
2 similar comments
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
=========================================
Coverage ? 93.15%
=========================================
Files ? 3
Lines ? 263
Branches ? 67
=========================================
Hits ? 245
Misses ? 18
Partials ? 0
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
=========================================
Coverage ? 93.15%
=========================================
Files ? 3
Lines ? 263
Branches ? 67
=========================================
Hits ? 245
Misses ? 18
Partials ? 0
Continue to review full report at Codecov.
|
This supersedes PR #5 by cherry-picking the commit by @koistya (resolving merge conflict) and then adding another commit where another
.catch(callback).then(...)
was causing a callback to be called twice, thus making Webpack throw an exception from inside theasync
module.