Fix misc problems in test code and webpack 4 #116
Conversation
|
|
|
And I fixed two problems in webpack 4.
Refs: |
leemars
changed the title
|
Any progress? |
| @@ -14,7 +14,7 @@ function isRelativePath(str) { | |||
|
|
|||
| function stringifyRequest(loaderContext, request) { | |||
| const splitted = request.split("!"); | |||
| const context = loaderContext.context || (loaderContext.options && loaderContext.options.context); | |||
| const context = loaderContext.context || loaderContext.rootContext || (loaderContext.options && loaderContext.options.context); | |||
There was a problem hiding this comment.
rootContext and context are difference, and it is invalid fix, rootContext is context for request, context is webpack context
There was a problem hiding this comment.
But according to this, this.options.context has been changed to this.rootContext. I thought this is just the loaderContext. Could you give me some more explanation? Thanks!
There was a problem hiding this comment.
hm, looks my mistake, can you create new PR?
| @@ -90,8 +91,9 @@ function interpolateName(loaderContext, name, options) { | |||
| ); | |||
| }); | |||
| } | |||
| if(typeof loaderContext.options === "object" && typeof loaderContext.options.customInterpolateName === "function") { | |||
| url = loaderContext.options.customInterpolateName.call(loaderContext, url, name, options); | |||
| const loaderContextOptions = getOptions(loaderContext); | |||
There was a problem hiding this comment.
Could you check this again? According to https://webpack.js.org/api/loaders/#this-options , this.options has been removed in webpack 4. And according to https://webpack.js.org/api/loaders/#this-query , we should use getOptions to extract given loader options.
|
Thanks for the PR, some problem already fixed, some invalid |
I fixed two problems when I run
npm run test.