Add [folder] token to interpolateName #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usure of whether this is the right way or not - will need to add more tests to confirm
|
@sokra Eager to get your feedback on this! I wasn't sure of the approach to take - I pondered doing |
|
Looks good, but I don't have time this week to merge it... Next week. |
|
@sokra Eagerly awaiting any updates you might have for this 😄 |
|
Thanks. Sorry for waiting so long. I was too busy. |
|
Awesome thanks for merging it in. 💃🏻🎉 Can't wait for it to be published! 👏🏼 |
This was referenced Apr 9, 2016
|
Thank you @joshhunt! I am admittedly a terrible open source developer and never did get round to doing tests for this... but I look forward to using it now! |
|
Haha good hustle @joshhunt! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11 appears to be abandoned so I took another crack at it - this time with tests!
I noticed @mrm007 did some work (in #26) on writing tests for
interpolateName, so I merged that in to extend from that. I would recommend his PR is merged before this one - once it is the diff here will more accurately show the work that I've done myself.Let me know if you have any feedback!