getLoaderConfig(): allow multiple default config properties #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows the user to pass an arbitrary number of default config property names to getLoaderConfig(), instead of just one. - If zero default config properties are passed, getLoaderConfig(context) will behave like parseQuery(context.query), unless the user passes a custom config property via the query string. - If one default config propery is passed, the behavior is unchanged. - If multiple default config properties are passed, the first such property on context.options will be used, unless no such property is present, in which case an empty object will be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
getLoaderConfig()to allow the user to pass an arbitrary number of defaultconfig property names to getLoaderConfig(), instead of just one.
See issue #33
This pull request does the following:
index.jsas described in issue Feature request: getLoaderConfig(loaderContext, ...defaultConfigKeys) #33test/index.jsto account for changesREADME.mdwith documentation on new changes