Fix stringifyRequest messing with loader configs #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhnns
force-pushed
the
fix/37-54-55-stringify-request
branch
3 times, most recently
from
792b6eb
to
bed252d
Compare
sokra
requested changes
Feb 15, 2017
test/index.js
Outdated
| win && { context: "C:\\path\\to\\thing", request: "C:\\path\\to\\module\\a.js", expected: s("../module/a.js") }, | ||
| // If context and request are on different hard drives, the path should not be relative | ||
| // @see https://github.com/webpack/loader-utils/pull/14 | ||
| win && { context: "D:\\path\\to\\thing", request: "C:\\path\\to\\module\\a.js", expected: s("C:/path/to/module/a.js") }, |
There was a problem hiding this comment.
expected: s("C:\\path\\to\\module\\a.js")
There was a problem hiding this comment.
I think, it would make sense to make / as the only separator for requests. Makes it easier for the future. And / are also valid on Windows.
What do you think?
test/index.js
Outdated
| loaderUtils = require("../"); | ||
|
|
||
| var s = JSON.stringify, | ||
| j = path.join; |
|
Thx for reviewing it. I will add that UNC test case. |
jhnns
force-pushed
the
fix/37-54-55-stringify-request
branch
from
bed252d
to
aa644a5
Compare
sokra
requested changes
Feb 17, 2017
README.md
Outdated
| loaderUtils.stringifyRequest(this, "C:\\module\\test.js"); | ||
| // "\"C:\\module\\test.js\"" (on Windows, in case the module and the request are on different drives) | ||
|
|
||
| loaderUtils.stringifyRequest(this, "\\network-drive\\test.js"); |
README.md
Outdated
| @@ -57,13 +57,41 @@ null -> {} | |||
|
|
|||
| ### `stringifyRequest` | |||
|
|
|||
| Makes a request pretty and stringifies it. Absolute paths are replaced with relative ones. | |||
| Turns a request into a string that can be used inside a `require()` or `import()` call or an `import` statement. | |||
| Use it instead of `JSON.stringify(...)` if you're generating code inside a loader. | |||
README.md
Outdated
| ``` javascript | ||
| loaderUtils.stringifyRequest(this, require.resolve("./test")); | ||
| // = "../node_modules/some-loader/lib/test.js" | ||
| - resolves module requests into relative requests |
There was a problem hiding this comment.
module request = "module/path"
relative request = "./relative/path"
stringifyRequest doesn't resolve one into another. Remove this line.
jhnns
force-pushed
the
fix/37-54-55-stringify-request
branch
from
aa644a5
to
9355c27
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stringifyRequest used to replace all backslashes with slashes inside the whole request, including loader configs. This fix separates first the config from the path before applying path normalizations.
It also adds tests.
#37 #54 #55