feat: make async callbacks call in a new event cycle (fixes #22)

webpack · Sep 7, 2016 · eeb7516 · eeb7516
1 parent 83e1ffc
commit eeb7516
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 4 deletions.
diff --git a/lib/MemoryFileSystem.js b/lib/MemoryFileSystem.js
@@ -278,9 +278,15 @@ MemoryFileSystem.prototype.createWriteStream = function(path, options) {
 		try {
 			var result = this[fn + "Sync"](path);
 		} catch(e) {
-			return callback(e);
+			process.nextTick(function() {
+				callback(e);
+			});
+
+			return;
 		}
-		return callback(null, result);
+		process.nextTick(function() {
+			callback(null, result);
+		});
 	};
 });
 
@@ -293,9 +299,15 @@ MemoryFileSystem.prototype.createWriteStream = function(path, options) {
 		try {
 			var result = this[fn + "Sync"](path, optArg);
 		} catch(e) {
-			return callback(e);
+			process.nextTick(function() {
+				callback(e);
+			});
+
+			return;
 		}
-		return callback(null, result);
+		process.nextTick(function() {
+			callback(null, result);
+		});
 	};
 });
 

diff --git a/test/MemoryFileSystem.js b/test/MemoryFileSystem.js
@@ -204,6 +204,28 @@ describe("errors", function() {
 	});
 });
 describe("async", function() {
+	["stat", "readdir", "mkdirp", "rmdir", "unlink", "readlink"].forEach(function(methodName) {
+		it("should call " + methodName + " callback in a new event cycle", function(done) {
+			var fs = new MemoryFileSystem();
+			var isCalled = false;
+			fs[methodName]('/test', function() {
+				isCalled = true;
+				done();
+			});
+			should(isCalled).eql(false);
+		});
+	});
+	["mkdir", "readFile"].forEach(function(methodName) {
+		it("should call " + methodName + " a callback in a new event cycle", function(done) {
+			var fs = new MemoryFileSystem();
+			var isCalled = false;
+			fs[methodName]('/test', {}, function() {
+				isCalled = true;
+				done();
+			});
+			should(isCalled).eql(false);
+		});
+	});
 	it("should be able to use the async versions", function(done) {
 		var fs = new MemoryFileSystem();
 		fs.mkdirp("/test/dir", function(err) {