For async mkdir, call the callback when passed as the third argument #18

elliottsj · 2016-03-15T18:24:36Z

This is for parity with the Node.js fs.mkdir implementation, which may optionally accept options as the 2nd argument.

Previously, using memory-fs along with mkdirp results in this error:

var fs = new MemoryFileSystem();
mkdirp('/some/dir', { fs: fs }, cb => {/*...*/})

TypeError: callback is not a function
    at MemoryFileSystem.(anonymous function) [as mkdir] (node_modules/memory-fs/lib/MemoryFileSystem.js:281:11)
    at mkdirP (node_modules/mkdirp/index.js:27:9)

This PR will resolve such errors.

This is for parity with the Node.js fs.mkdir implementation, which may accept optional options as the 2nd argument.

sokra · 2016-09-07T17:05:04Z

Thanks

For async mkdir, call the callback when passed as the third argument

4bd3ce4

This is for parity with the Node.js fs.mkdir implementation, which may accept optional options as the 2nd argument.

sokra merged commit 804dfa1 into webpack:master Sep 7, 2016

elliottsj deleted the mkdir-callback branch September 8, 2016 04:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

For async mkdir, call the callback when passed as the third argument #18

For async mkdir, call the callback when passed as the third argument #18

elliottsj commented Mar 15, 2016

sokra commented Sep 7, 2016

For async mkdir, call the callback when passed as the third argument #18

For async mkdir, call the callback when passed as the third argument #18

Conversation

elliottsj commented Mar 15, 2016

sokra commented Sep 7, 2016