Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize UNC paths correctly. #34

Merged
merged 1 commit into from
Jun 1, 2017
Merged

Normalize UNC paths correctly. #34

merged 1 commit into from
Jun 1, 2017

Conversation

amanda-mitchell
Copy link
Contributor

On Windows, paths to network shares begin with a \\ (for example, \\remote-computer\sharedFolder\file), and these paths are inappropriately reduced to beginning with a single backslash by memory-fs's normalize function.

This PR fixes that.

@jsf-clabot
Copy link

jsf-clabot commented Dec 29, 2016

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Dec 29, 2016

Codecov Report

Merging #34 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   95.95%   95.98%   +0.02%     
==========================================
  Files           3        3              
  Lines         272      274       +2     
  Branches       62       63       +1     
==========================================
+ Hits          261      263       +2     
  Misses         11       11
Impacted Files Coverage Δ
lib/normalize.js 83.33% <100%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79a02a6...510260a. Read the comment docs.

@sokra sokra merged commit 4b96090 into webpack:master Jun 1, 2017
@sokra
Copy link
Member

sokra commented Jun 1, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants