Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minLength maxLength wrong format string #65

Closed
vankop opened this issue Oct 3, 2019 · 2 comments
Closed

minLength maxLength wrong format string #65

vankop opened this issue Oct 3, 2019 · 2 comments
Labels
type: Bug

Comments

@vankop
Copy link
Member

vankop commented Oct 3, 2019 •
edited

  • Operating System:
  • Node Version:
  • NPM Version:
  • webpack Version:
  • schema-utils Version:

Expected Behavior

For

{
      "format": "[0-9]*",
      "minLength": 10
}

Expect:
should be longer than 9 characters

Actual Behavior

should be shorter than 10 characters

Code

https://github.com/webpack/schema-utils/blob/master/src/ValidationError.js#L412

Same for maxLength
vankop added a commit to vankop/schema-utils that referenced this issue Oct 3, 2019
@vankop
fix: webpack#65 , add tests for stringHints
85b3207
@alexander-akait
Copy link
Member

Let's fix it 👍

@vankop vankop mentioned this issue Oct 4, 2019
Closed
6 tasks
@vankop vankop mentioned this issue Oct 13, 2019
Merged
6 tasks
@alexander-akait
Copy link
Member

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support inner not, not in simple types vankop/schema-utils
2 participants
@alexander-akait @vankop