Merge pull request #122 from webpack/bugfix/stack-overflow

avoid generating too depth scope nesting

lib/HookCodeFactory.js

@@ -279,13 +279,17 @@ class HookCodeFactory {
 	}) {
 		if (this.options.taps.length === 0) return onDone();
 		const firstAsync = this.options.taps.findIndex(t => t.type !== "sync");
-		const somethingReturns = resultReturns || doneReturns || false;
+		const somethingReturns = resultReturns || doneReturns;
 		let code = "";
 		let current = onDone;
+		let unrollCounter = 0;
 		for (let j = this.options.taps.length - 1; j >= 0; j--) {
 			const i = j;
-			const unroll = current !== onDone && this.options.taps[i].type !== "sync";
+			const unroll =
+				current !== onDone &&
+				(this.options.taps[i].type !== "sync" || unrollCounter++ > 20);
 			if (unroll) {
+				unrollCounter = 0;
 				code += `function _next${i}() {\n`;
 				code += current();
 				code += `}\n`;

lib/__tests__/AsyncSeriesHooks.js

@@ -51,6 +51,16 @@ describe("AsyncSeriesBailHook", () => {
 
 		expect(result).toMatchSnapshot();
 	});
+
+	it("should not crash with many plugins", () => {
+		const hook = new AsyncSeriesBailHook(["x"]);
+		for (let i = 0; i < 1000; i++) {
+			hook.tap("Test", () => 42);
+		}
+		hook.tapAsync("Test", (x, callback) => callback(null, 42));
+		hook.tapPromise("Test", x => Promise.resolve(42));
+		return expect(hook.promise()).resolves.toBe(42);
+	});
 });
 
 describe("AsyncSeriesWaterfallHook", () => {

lib/__tests__/SyncBailHook.js

@@ -82,6 +82,14 @@ describe("SyncBailHook", () => {
 		const hook = new SyncBailHook(["x"]);
 		expect(() => hook.tapPromise()).toThrow(/tapPromise/);
 	});
+
+	it("should not crash with many plugins", () => {
+		const hook = new SyncBailHook(["x"]);
+		for (let i = 0; i < 1000; i++) {
+			hook.tap("Test", () => 42);
+		}
+		expect(hook.call()).toBe(42);
+	});
 });
 
 function pify(fn) {