Emit change events for nested directory watchers #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed files don't have an mtime. Adding FS_ACCURACY to a 0 or null mtime results in a non-zero mtime for any FS_ACCURACY that is non-zero. Other parts of the source rely on mtime being falsy when items are removed.
For nested watchers, if the parent watcher or nested watcher has finished its initial scan emit any new changes on the directory's watcher. This is similar to each shallow directory watcher which emits a change event for every file change after the initial scan of that directory. The nested watchers though need to consider if the parent finished its initial scan if so, any files found during the initial scan for the nested directory should also be emitted as this is a new directory created after the parent's initial scan.
|
|
|
I included a change like #33. Happy to drop that commit or make any desired changes. |
|
I haven't really looked into this, but would it be possible to add a test for this? That would ensure it will not be removed accidentally in the future... |
This was referenced Dec 26, 2016
|
fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #28
Change events are emitted on directory watchers for the immediate
directory being watched after the initial scan. Emit events from nested
watchers after their parents initial scan (they're a new directory) or
after their own scan (the directory existed during their parents
initial scan).