Add remove event #37
Closed
Add remove event #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI tests seem to be failing, could you look into this? Note that the builds on macOS for Travis are currently always failing, but the Linux tests shouldn't fail. |
|
@SpaceK33z Fixed. Just needed to merge #33. |
|
Is there anything we need to do to get this moving forward? |
|
rebased and merged. Thanks |
This was referenced Dec 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27
Depends on #33
removeeventaggregateevent.This is based on the work for next.js, which we dynamically patch on runtime for now. cc @TheLarkInn