Update, Refactor, and Reorg #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implementing separate static manager file reorganizing tests refactoring tests all tests now pass on Darwin removing rimraf in favor of del (safer)
|
|
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
- Coverage 95.67% 89.97% -5.71%
==========================================
Files 3 5 +2
Lines 347 359 +12
Branches 90 89 -1
==========================================
- Hits 332 323 -9
- Misses 15 36 +21
Continue to review full report at Codecov.
|
shellscape
changed the title
|
@sokra this should be ready to go. I can't duplicate any of the CI failures locally - everything passes on my end. Not sure how to resolve, any suggestions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a comprehensive ES6 update (Node 6 minimum), refactor, and reorganization of the codebase. Changes include:
eslint-config-webpack-contribshouldin favor ofassertto assist with future move tojest