Add option to change followSymlinks #72

immortal-tofu · 2018-03-16T14:03:31Z

There is many projects who need to configure this option. This simple PR allow to pass a followSymlinks options to change it. Default is still false.

Webpack issue:
webpack/webpack#1866

Watchpack issue:
#61

jsf-clabot · 2018-03-16T14:03:33Z

All committers have signed the CLA.

alexander-akait · 2018-03-16T14:04:54Z

lib/DirectoryWatcher.js

@@ -51,7 +51,7 @@ function DirectoryWatcher(directoryPath, options) {
 	this.watcher = chokidar.watch(directoryPath, {
 		ignoreInitial: true,
 		persistent: true,
-		followSymlinks: false,
+		followSymlinks: !!options.followSymlinks,


Breaking change, default is not false, default is boolean value options.followSymlinks

If you don't specify options.followSymlinks, it will be undefined. Well, we'll have !!options.followSymlinks === !!undefined === false. So yes, default is still false, no breaking change.

@birdy- hm, you are right

codecov · 2018-03-16T14:12:48Z

Codecov Report

Merging #72 into master will decrease coverage by 0.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage    95.5%   95.22%   -0.29%     
==========================================
  Files           3        3              
  Lines         356      356              
  Branches       97       97              
==========================================
- Hits          340      339       -1     
- Misses         16       17       +1

Impacted Files	Coverage Δ
lib/DirectoryWatcher.js	`95% <ø> (-0.42%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d839e8...22cda93. Read the comment docs.

RomainGiordano · 2018-03-16T15:47:30Z

Let's ship it

adrianodimarco · 2018-03-16T15:48:08Z

Yes, ship it!

shunxing · 2018-03-16T15:49:10Z

Go ahead

alexander-akait · 2018-03-16T15:52:09Z

I sent link on PR in closed webpack slack channel, just wait 👍

ooflorent

This change looks fine. However, how would you set this option in webpack? Could you post an example here?

immortal-tofu · 2018-03-16T16:18:59Z

I think it would be next to symlink: false|true in resolve section, but tbh it can be discussed.

resolve: {
  ...
  symlink: false,
  followSymlinks: true,
},

ooflorent · 2018-03-16T16:36:58Z

Then you should also submit a PR to update the schema if this one lands 👍

ooflorent · 2018-03-16T16:38:11Z

I'm tempted to accept the PR but I'm worried about having symlink and followSymlinks options. This is not very intuitive for newcomers...

immortal-tofu · 2018-03-16T17:00:48Z

I'll open a PR, but I'll have to update package.json's dependencies as well since it will be mandatory to update watchpack.
You can merge this part, and we'll discuss about the name in webpack on the future PR.

TheLarkInn · 2018-03-17T00:11:39Z

@ooflorent I definitely agree with you. Can we open up an issue slated for v5 so we can change the default to be what the user also expects out of the box.

immortal-tofu · 2018-03-23T10:03:23Z

Added an issue on webpack webpack/webpack#6845

oliverguenther · 2018-06-21T12:44:19Z

Anything we can do to help this move forward? When using followSymlinks with either npm link or, e.g., Angular CLI, this is a serious issue that I would hope to use in v4 already. Overriding the flag manually does work but is a very brittle workaround.

Globegitter · 2018-08-11T12:05:55Z

Yep, can this please get merged? Seems there are quite a few people who would benefit from this change and merging it here is the first step necessary to make it possible to add it to webpack - and also just because it is merged here does not mean that webpack has to expose the option yet.

Also following semver this is a backwards compatible change and should ideally be shipped with v4.

joeybaker · 2018-09-07T16:55:14Z

@birdy- maybe you could rebase this branch? It would be great to get this merged!

immortal-tofu · 2018-09-07T19:09:52Z

I rebased. Ready to ship it captain'

joeybaker · 2018-09-07T19:24:17Z

@ooflorent @evilebottnawi @TheLarkInn Would it be possible to get another look at this PR? It would be a really helpful bug fix.

codecov · 2018-09-18T19:12:51Z

Codecov Report

Merging #72 into master will decrease coverage by 0.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage    95.5%   95.22%   -0.29%     
==========================================
  Files           3        3              
  Lines         356      356              
  Branches       97       97              
==========================================
- Hits          340      339       -1     
- Misses         16       17       +1

Impacted Files	Coverage Δ
lib/DirectoryWatcher.js	`95% <ø> (-0.42%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d839e8...22cda93. Read the comment docs.

codecov · 2018-09-18T20:49:11Z

Codecov Report

Merging #72 into master will decrease coverage by 0.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage    95.5%   95.22%   -0.29%     
==========================================
  Files           3        3              
  Lines         356      356              
  Branches       97       97              
==========================================
- Hits          340      339       -1     
- Misses         16       17       +1

Impacted Files	Coverage Δ
lib/DirectoryWatcher.js	`95% <ø> (-0.42%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d839e8...22cda93. Read the comment docs.

joeybaker · 2018-09-19T18:13:38Z

Is the drop in code coverage a blocker on getting this merged?

Madorakkusu · 2018-10-10T14:51:25Z

Can we ship it ?

abhafedh · 2018-10-10T14:52:11Z

we need that pleaaaaaase :( ship it

DeTeam · 2018-10-24T12:58:38Z

Once this lands, we can remove a couple of linux-specific hacks in our projects, symlink-related.

ingdir · 2018-10-24T13:01:34Z

We have a really dirty hack in our system for a linux-based project, that one can be removed if this gets merged. Would be great to ship it.

kostspielig · 2018-10-24T13:07:30Z

This is much needed for us! To be merged soon? 👍

sibelius · 2018-10-25T20:03:48Z

this would be cool

mko · 2018-11-08T19:54:58Z

This is needed for our project as well. It would be really useful to have this released ASAP.

DeTeam · 2018-12-14T14:03:32Z

@ooflorent any chance to have a look at this PR? ^_^

bfutterleib · 2019-01-23T21:55:26Z

+1 love to have this, free hugs?

Globegitter · 2019-02-19T13:34:35Z

@sokra what is the story now with watchpack 2? It seems you implement your own watcher now. Does this support a followSymlink option?

dhonx · 2019-06-14T21:37:27Z

I also got the same problem ... thank you everyone ... I think the webpack team would be very good if adding this feature (follow Symlink option)

sokra · 2019-07-10T18:10:33Z

#114 adds the followSymlink option

immortal-tofu mentioned this pull request Mar 16, 2018

[BUG?] npm link causes Webpack to look for babel-plugin in linked package node_modules. webpack/webpack#1866

Closed

alexander-akait reviewed Mar 16, 2018

View reviewed changes

ooflorent reviewed Mar 16, 2018

View reviewed changes

immortal-tofu mentioned this pull request Mar 23, 2018

Add option to enable/disable followSymlinks of watchpack webpack/webpack#6845

Closed

Add option to change followSymlinks

22cda93

immortal-tofu force-pushed the feature-option-followSymlinks branch from 2681e79 to 22cda93 Compare September 7, 2018 19:08

NathanaelA mentioned this pull request Sep 14, 2018

HMR, and plugin development (npm link) issues NativeScript/nativescript-dev-webpack#656

Closed

9 tasks

SEAPUNK mentioned this pull request Feb 19, 2019

Watch doesn`t work correctly with links #60

Closed

sokra closed this Jul 10, 2019

Add option to change followSymlinks #72

Add option to change followSymlinks #72

Conversation

immortal-tofu commented Mar 16, 2018

jsf-clabot commented Mar 16, 2018 • edited

alexander-akait Mar 16, 2018

Choose a reason for hiding this comment

immortal-tofu Mar 16, 2018

Choose a reason for hiding this comment

alexander-akait Mar 16, 2018

Choose a reason for hiding this comment

codecov bot commented Mar 16, 2018 • edited

Codecov Report

RomainGiordano commented Mar 16, 2018

adrianodimarco commented Mar 16, 2018

shunxing commented Mar 16, 2018

alexander-akait commented Mar 16, 2018 • edited

ooflorent left a comment

Choose a reason for hiding this comment

immortal-tofu commented Mar 16, 2018 • edited

ooflorent commented Mar 16, 2018 • edited

ooflorent commented Mar 16, 2018

immortal-tofu commented Mar 16, 2018

TheLarkInn commented Mar 17, 2018

immortal-tofu commented Mar 23, 2018

oliverguenther commented Jun 21, 2018

Globegitter commented Aug 11, 2018 • edited

joeybaker commented Sep 7, 2018 • edited

immortal-tofu commented Sep 7, 2018

joeybaker commented Sep 7, 2018

codecov bot commented Sep 18, 2018

Codecov Report

codecov bot commented Sep 18, 2018 • edited

Codecov Report

joeybaker commented Sep 19, 2018

Madorakkusu commented Oct 10, 2018

abhafedh commented Oct 10, 2018

DeTeam commented Oct 24, 2018

ingdir commented Oct 24, 2018

kostspielig commented Oct 24, 2018

sibelius commented Oct 25, 2018

mko commented Nov 8, 2018

DeTeam commented Dec 14, 2018

bfutterleib commented Jan 23, 2019

Globegitter commented Feb 19, 2019

dhonx commented Jun 14, 2019

sokra commented Jul 10, 2019

jsf-clabot commented Mar 16, 2018 •

edited

codecov bot commented Mar 16, 2018 •

edited

alexander-akait commented Mar 16, 2018 •

edited

immortal-tofu commented Mar 16, 2018 •

edited

ooflorent commented Mar 16, 2018 •

edited

Globegitter commented Aug 11, 2018 •

edited

joeybaker commented Sep 7, 2018 •

edited

codecov bot commented Sep 18, 2018 •

edited