Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): fix file resolution inside group helper #1221

Merged
merged 2 commits into from
Feb 12, 2020

Conversation

ematipico
Copy link
Contributor

What kind of change does this PR introduce?

Fixes #1215

Did you add tests for your changes?
YEs

If relevant, did you update the documentation?
Nope

Summary
Making sure that the ZeroConfigGroup class is able to import the correct files.

Does this PR introduce a breaking change?

Other information

Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One test needs to be fixed, rest looks good to me.

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@rishabh3112 rishabh3112 merged commit 76d2eb3 into webpack:next Feb 12, 2020
@ematipico ematipico deleted the bugfix/production-flag branch February 12, 2020 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4.0.0-beta.2 module error
4 participants