Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ci for webpack@beta.30 #1801

Merged
merged 16 commits into from Sep 16, 2020
Merged

fix: ci for webpack@beta.30 #1801

merged 16 commits into from Sep 16, 2020

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Sep 13, 2020

What kind of change does this PR introduce?
tests

Did you add tests for your changes?
yes
If relevant, did you update the documentation?

Summary
fixed failing tests for webpack@beta.30

Does this PR introduce a breaking change?
no

Other information

@snitin315
Copy link
Member Author

/cc @webpack/cli-team , help output is not working anymore. It looks like issue in chalk or command-line-usage.

Screenshot at 2020-09-13 08-13-55

Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine for me at next.

image

Working fine on your branch as well

image

Check your local setup once :).

@snitin315
Copy link
Member Author

Failing in CI as well, for webpack@next.

@snitin315
Copy link
Member Author

Check your local setup once :).

Screenshot at 2020-09-13 13-30-03

@rishabh3112 Can you check with webpack 5.0.0-beta.30?

@alexander-akait
Copy link
Member

@snitin315 weird, we migrate from chalk 😕

@snitin315
Copy link
Member Author

But command-line-usage is still using chalk as a dep. There are two possible solutions that I can think of right now -

  • We can use the commander.js default help output for webpack@next. (Quick fix).
  • Our custom utility for help output.

@rishabh3112
Copy link
Member

Can you check with webpack 5.0.0-beta.30?

Yeah, I did. I reproduced the error too. It is after latest pre-release of webpack v5 as previous version of v5 is working fine. Please check for changes in it where flag description was either added or edited.

@snitin315
Copy link
Member Author

Can you check with webpack 5.0.0-beta.30?

Yeah, I did. I reproduced the error too. It is after latest pre-release of webpack v5 as previous version of v5 is working fine. Please check for changes in it where flag description was either added or edited.

Ah yes! Looking into it.

@snitin315
Copy link
Member Author

Yes, help output is working after I remove these flags. Should I create a PR to update these descriptions at the core?

@rishabh3112
Copy link
Member

Yes @snitin315, go ahead!

@alexander-akait
Copy link
Member

@snitin315 I think we need escape some characters

@snitin315
Copy link
Member Author

Yes, I did some more research and found a similar issue Polymer/tools#595 and PR Polymer/tools#612

@snitin315
Copy link
Member Author

Not sure why serve tests are failing on CI, they are passing locally
Screenshot at 2020-09-14 21-24-58

@snitin315 snitin315 marked this pull request as ready for review September 16, 2020 14:45
@snitin315 snitin315 requested a review from a team as a code owner September 16, 2020 14:45
@snitin315 snitin315 changed the title fix: ci fix: ci for webpack@beta.30 Sep 16, 2020
@snitin315
Copy link
Member Author

/cc @webpack/cli-team ready for review 👍🏻

@evenstensberg evenstensberg merged commit cb38d63 into next Sep 16, 2020
@evenstensberg evenstensberg deleted the fix/ci branch September 16, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants