Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Output flag should only set path #1844

Closed
anshumanv opened this issue Sep 28, 2020 · 2 comments · Fixed by #1855
Closed

Bug: Output flag should only set path #1844

anshumanv opened this issue Sep 28, 2020 · 2 comments · Fixed by #1855
Assignees
Labels

Comments

@anshumanv
Copy link
Member

Describe the bug

@evilebottnawi : It is invalid because we will specify HTML and CSS as entry points in the near future + dependOn, if you have HTML entrypoint and use --output=/path/to/file.js it was wrong, Ideally we should remove --output in favor --output-path, also this one will be consistent with webpack@5 cli args

What is the current behavior?

Passing a file in output flag sets filename object in output

To Reproduce
Pass /path/to/file.js

Expected behavior
It should only set output.path, filename should only be configured using config

Screenshots

Please paste the results of webpack-cli info here, and mention other relevant information

Additional context
#1832 (comment)

@anshumanv anshumanv added the Bug label Sep 28, 2020
@anshumanv anshumanv self-assigned this Sep 28, 2020
@alexander-akait
Copy link
Member

I think better to remove --output in favor --output-path

@anshumanv
Copy link
Member Author

Yep will do that in PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants