fix(serve): do not default host in webpack-dev-server v4 #2141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Codecov Report
@@ Coverage Diff @@
## master #2141 +/- ##
=======================================
Coverage 68.65% 68.65%
=======================================
Files 73 73
Lines 2386 2386
Branches 512 512
=======================================
Hits 1638 1638
Misses 748 748
Continue to review full report at Codecov.
|
| @@ -36,9 +36,9 @@ export default function startDevServer(compiler, cliOptions): object[] { | |||
| const usedPorts: number[] = []; | |||
| devServerOptions.forEach((devServerOpts): void => { | |||
| const options = mergeOptions(cliOptions, devServerOpts); | |||
| options.host = options.host || 'localhost'; | |||
| // devSever v4 handles the default port itself | |||
| // devSever v4 handles the default host and port itself | |||
There was a problem hiding this comment.
I think we can break compatibility with webpack-dev-server@3, I think we need do it by default for else branch
There was a problem hiding this comment.
isDevServer4 is negated in the condition.
There was a problem hiding this comment.
I definitely need a vacation
alexander-akait
approved these changes
Nov 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
Did you add tests for your changes?
Integration tests will be possible once after webpack-dev-server v4 has been released.
If relevant, did you update the documentation?
N/A
Summary
#2126 (comment)
With webpack/webpack-dev-server#2869, it'd be possible to pass
undefinedas the host to letlisten()handle the address to bind to.Depends on the PR above.
Does this PR introduce a breaking change?
N/A
Other information