-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: simplify init #2429
feat: simplify init #2429
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2429 +/- ##
===========================================
+ Coverage 72.60% 90.82% +18.21%
===========================================
Files 46 29 -17
Lines 2234 1449 -785
Branches 603 411 -192
===========================================
- Hits 1622 1316 -306
+ Misses 612 133 -479
Continue to review full report at Codecov.
|
Self Reminder: Add tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good job, but I think we should still leave some questions:
- dev server
- CSS
- babel
- typescript
- html-webpack-plugin
Because it is very popular and will be great to newbie + adding scripts - serve
, build
, dev
, watch
(maybe more or less). What do you think? Maybe I be some misleading. I mean we should not analyze webpack.config.js
and just ask questions.
What question should we ask regarding this? I am thinking of |
Sounds good and simple |
I didn't understand what you meant in case we have CSS and JS rules, currently I am not adding asset module support when either of CSS and JS languages solutions are opted. |
If we don't add it, all
|
/cc @webpack/cli-team Need review, we will improve it more in the next PRs, basic work is done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well donee 💯
What kind of change does this PR introduce?
Feature
Did you add tests for your changes?
WIP
If relevant, did you update the documentation?
Will do after implementation
Summary
Simplify the init feature to just scaffold configuration, without ast transformations.
Does this PR introduce a breaking change?
Yes
Other information
WIP