Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack-cli init command error #291

Closed
dhruvdutt opened this issue Feb 26, 2018 · 14 comments
Closed

webpack-cli init command error #291

dhruvdutt opened this issue Feb 26, 2018 · 14 comments

Comments

@dhruvdutt
Copy link
Member

dhruvdutt commented Feb 26, 2018

webpack-cli version

Latest tree. (2.0.9) Using symlink.

What is the current behavior?

Using webpack-cli init with mostly default recommended options.

screenshot_20180227_032131

After all dependencies are installed, I get this error:

image

Generated package.json

image

Steps to reproduce

mkdir test-dir && cd test-dir;
mkdir src && touch src/index.js;
webpack-cli init

What is the expected behavior?

webpack-cli init should run and create a webpack project with a config file.

@SolarLiner
Copy link

Can confirm on Ubuntu 17.10 - webpack-cli fails at the last moment with the same error.

Makes webpack-cli useless to me 🤷‍♂️

@evenstensberg
Copy link
Member

I'll have a look at this tomorrow, our fork isn't cooperating :(

@kawasako
Copy link

Hi. I also experienced this problem. In my opinion, maybe, this change is the cause. 0b4269c#diff-b9cfc7f2cdf78a7f4b91a753d10865a2

Since yoeman-environment refers to youeman-generator, I think that behavior has changed with this change.

@dhruvdutt
Copy link
Member Author

@kawasako yeoman-environment doesn't have any peerDependency for yeoman-generator so there aren't any issues with namespacing.

@kawasako
Copy link

@dhruvdutt your right. (I'm sorry) I studied further in detail, The real cause is that webpack-fork-yeoman-generator is published from master branch. There is no implementation of getArgument here. https://github.com/ev1stensberg/generator/blob/master/package.json#L2

@dhruvdutt
Copy link
Member Author

dhruvdutt commented Feb 27, 2018

@kawasako Yeah, I think that could be an issue as well.
Can you please try my PR #294 or branch locally and test if it's working? I don't think we need a separately published package if this one works.

@kawasako
Copy link

@dhruvdutt I tested it. It seems to work well about webpack-cli init.

@dhruvdutt
Copy link
Member Author

Awesome. 🚀

@williamnerdy
Copy link

I have the same problem

@justerest
Copy link

justerest commented Feb 28, 2018

I have the same problem

Linux justerest-pc 4.9.0-6-amd64 #1 SMP Debian 4.9.82-1+deb9u2 (2018-02-21) x86_64 GNU/Linux

@dhruvdutt
Copy link
Member Author

dhruvdutt commented Feb 28, 2018

@ev1stensberg The init command is broken on our latest published version. 💔

Can you please test and review #294 or else we will have to find some other fix.

@justerest
Copy link

it fixs the problem but I just use v2.0.7 now

@evenstensberg
Copy link
Member

webpack-cli v.2.0.10 should fix this. Publishing in a few hours

@dhruvdutt
Copy link
Member Author

dhruvdutt commented Mar 2, 2018

2.0.10 is out with the fix. 🔥

@SolarLiner @kawasako @williamnerdy @justerest
Please test and let us know if you still have any issues. 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants