Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack is not listed as a peer #295

Closed
waterfoul opened this issue Feb 27, 2018 · 5 comments
Closed

webpack is not listed as a peer #295

waterfoul opened this issue Feb 27, 2018 · 5 comments

Comments

@waterfoul
Copy link

Do you want to request a feature or report a bug?
bug

What is the current behavior?
you can install webpack-cli witghout webpack and get no warning

If the current behavior is a bug, please provide the steps to reproduce.
npm install webpack-cli on an empty project

What is the expected behavior?
An npm peer requirement warning

If this is a feature request, what is motivation or use case for changing the behavior?

Please mention other relevant information such as the browser version, Node.js version, Operating System and programming language.

@dhruvdutt
Copy link
Member

dhruvdutt commented Feb 27, 2018

I think fix should be to add webpack to "peerDependencies" inside package.json.

What minimum version of webpack do we support?

@ematipico
Copy link
Contributor

Version 4

@dhruvdutt
Copy link
Member

dhruvdutt commented Feb 28, 2018

@ematipico I'm not sure about other commands but as per the docs the migrate command only supports migrations from version 1 to 2.
Are the docs stale?

@ematipico
Copy link
Contributor

Webpack supports migration from 1 to 2 as you stated but the whole cli is officially ported since webpack 4.

From webpack 1 to 3 there was no need to have the cli installed. The cli was a plus (migration, creation of the config file)

From v4 the entire cli of webpack has been ported inside this repository, hence we needed to have a double relationship between webpack and the cli itself. So the first version that we have to support is 4.

@dhruvdutt
Copy link
Member

@ematipico Makes sense. I did a PR to add it. #297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants