refactor: replace deprecated String.prototype.substr() (#1227)

webpack · Mar 18, 2022 · d9ed56f · d9ed56f
1 parent 19dc401
commit d9ed56f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/src/utils/getFilenameFromUrl.js b/src/utils/getFilenameFromUrl.js
@@ -86,7 +86,7 @@ function getFilenameFromUrl(context, url) {
 
       // Strip the `pathname` property from the `publicPath` option from the start of requested url
       // `/complex/foo.js` => `foo.js`
-      const pathname = urlObject.pathname.substr(
+      const pathname = urlObject.pathname.slice(
         publicPathObject.pathname.length
       );
 

diff --git a/src/utils/setupWriteToDisk.js b/src/utils/setupWriteToDisk.js
@@ -53,7 +53,7 @@ function setupWriteToDisk(context) {
               const queryStringIdx = targetFile.indexOf("?");
 
               if (queryStringIdx >= 0) {
-                targetFile = targetFile.substr(0, queryStringIdx);
+                targetFile = targetFile.slice(0, queryStringIdx);
               }
 
               let { outputPath } = compiler;

diff --git a/test/middleware.test.js b/test/middleware.test.js
@@ -281,7 +281,7 @@ describe.each([
           expect(response.headers["content-type"]).toEqual(
             "application/javascript; charset=utf-8"
           );
-          expect(response.text).toBe(codeContent.substr(3000, 501));
+          expect(response.text).toBe(codeContent.slice(3000, 3501));
           expect(response.text.length).toBe(501);
         });
 
@@ -314,7 +314,7 @@ describe.each([
           expect(response.headers["content-type"]).toEqual(
             "application/javascript; charset=utf-8"
           );
-          expect(response.text).toBe(codeContent.substr(3000, 501));
+          expect(response.text).toBe(codeContent.slice(3000, 3501));
           expect(response.text.length).toBe(501);
         });
 
@@ -331,7 +331,7 @@ describe.each([
           expect(response.headers["content-type"]).toEqual(
             "application/javascript; charset=utf-8"
           );
-          expect(response.text).toBe(codeContent.substr(3000, 501));
+          expect(response.text).toBe(codeContent.slice(3000, 3501));
           expect(response.text.length).toBe(501);
         });
 
@@ -348,7 +348,7 @@ describe.each([
           expect(response.headers["content-type"]).toEqual(
             "application/javascript; charset=utf-8"
           );
-          expect(response.text).toBe(codeContent.substr(0, 3501));
+          expect(response.text).toBe(codeContent.slice(0, 3501));
           expect(response.text.length).toBe(3501);
         });
 
@@ -365,7 +365,7 @@ describe.each([
           expect(response.headers["content-type"]).toEqual(
             "application/javascript; charset=utf-8"
           );
-          expect(response.text).toBe(codeContent.substr(0, 801));
+          expect(response.text).toBe(codeContent.slice(0, 801));
           expect(response.text.length).toBe(801);
         });