Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A wild test appeared #121

Closed
12 of 15 tasks
SpaceK33z opened this issue Sep 10, 2016 · 3 comments
Closed
12 of 15 tasks

A wild test appeared #121

SpaceK33z opened this issue Sep 10, 2016 · 3 comments

Comments

@SpaceK33z
Copy link
Member

SpaceK33z commented Sep 10, 2016

So I started with writing the first test for this repo... Finally!

Here's a roadmap of things to test:

  • GetFilenameFromUrl
  • full test with express
  • webpackDevMiddleware.waitUntilValid
  • webpackDevMiddleware.invalidate
  • webpackDevMiddleware.close
  • handleRangeHeaders
  • compiler done event
  • compiler invalid event
  • compiler watch-run event
  • compiler run event
  • lazy mode
  • reporter option
  • serverSideRender option
  • /index.html should work
  • given headers should be set on response
SpaceK33z added a commit that referenced this issue Sep 11, 2016
@SpaceK33z
Copy link
Member Author

@wuct, I started writing some tests. I'm having some trouble with testing your serverSideRender option. See Server.test.js. Would you be able to help me by either fixing it with a PR, or giving some clues?

@wuct wuct mentioned this issue Sep 12, 2016
@wuct
Copy link
Contributor

wuct commented Sep 12, 2016

@SpaceK33z I fix the test by #122.

@wuct
Copy link
Contributor

wuct commented Sep 12, 2016

In short, requests for bundle files would still be responded by webpack-dev-middleware, so the next middleware would never be invoked.

SpaceK33z added a commit that referenced this issue Sep 12, 2016
SpaceK33z added a commit that referenced this issue Sep 12, 2016
SpaceK33z added a commit that referenced this issue Sep 13, 2016
SpaceK33z added a commit that referenced this issue Sep 13, 2016
SpaceK33z added a commit that referenced this issue Sep 13, 2016
SpaceK33z added a commit that referenced this issue Sep 15, 2016
SpaceK33z added a commit that referenced this issue Sep 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants