Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): fix writeToDisk example #342

Merged
merged 2 commits into from Oct 19, 2018
Merged

docs(readme): fix writeToDisk example #342

merged 2 commits into from Oct 19, 2018

Conversation

ooade
Copy link
Contributor

@ooade ooade commented Oct 19, 2018

What kind of change does this PR introduce?

Minor README correction

Does this PR introduce a breaking change?
No

@jsf-clabot
Copy link

jsf-clabot commented Oct 19, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 19, 2018

Codecov Report

Merging #342 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #342   +/-   ##
======================================
  Coverage    96.8%   96.8%           
======================================
  Files           7       7           
  Lines         250     250           
======================================
  Hits          242     242           
  Misses          8       8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc46398...167a9ef. Read the comment docs.

@michael-ciniawsky michael-ciniawsky changed the title Fix write to disk example docs(README): fix writeToDisk example Oct 19, 2018
Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ooade Thx

@michael-ciniawsky michael-ciniawsky changed the title docs(README): fix writeToDisk example docs(readme): fix writeToDisk example Oct 19, 2018
@michael-ciniawsky michael-ciniawsky added this to the 3.4.1 milestone Oct 19, 2018
@michael-ciniawsky michael-ciniawsky merged commit a59b9fd into webpack:master Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants