Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(middleware): do not add 'null' to Content-Type #355

Merged
merged 1 commit into from Jan 4, 2019

Conversation

clshortfuse
Copy link
Contributor

fixes: #354

What kind of change does this PR introduce?

bugfix

Did you add tests for your changes?

Of course!

Summary

Do not pass 'null' as media-type when mime-type lookup fails.

See #354

Does this PR introduce a breaking change?

No

@jsf-clabot
Copy link

jsf-clabot commented Jan 1, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@codecov
Copy link

codecov bot commented Jan 1, 2019

Codecov Report

Merging #355 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #355   +/-   ##
=======================================
  Coverage   96.82%   96.82%           
=======================================
  Files           7        7           
  Lines         252      252           
=======================================
  Hits          244      244           
  Misses          8        8
Impacted Files Coverage Δ
lib/middleware.js 94.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6cfe7c...dc9aa4e. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 1, 2019

Codecov Report

Merging #355 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #355   +/-   ##
=======================================
  Coverage   96.82%   96.82%           
=======================================
  Files           7        7           
  Lines         252      252           
=======================================
  Hits          244      244           
  Misses          8        8
Impacted Files Coverage Δ
lib/middleware.js 94.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6cfe7c...dc9aa4e. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thanks!

@alexander-akait alexander-akait merged commit cf4d7a9 into webpack:master Jan 4, 2019
gpoitch added a commit to gpoitch/webpack-dev-middleware that referenced this pull request Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: unknown mime type sets Content-Type as 'null; charset=UTF-8'
3 participants