chore(default): migrate #394
Conversation
alexander-akait
force-pushed
the
chore(default)-migrate
branch
from
30ca3d7
to
0ae1816
Compare
Codecov Report
@@ Coverage Diff @@
## master #394 +/- ##
==========================================
+ Coverage 96.86% 97.03% +0.17%
==========================================
Files 13 7 -6
Lines 287 304 +17
Branches 83 103 +20
==========================================
+ Hits 278 295 +17
Misses 9 9
Continue to review full report at Codecov.
|
| rules: { | ||
| 'prettier/prettier': ['error'], | ||
| strict: ['error', 'safe'], | ||
| strict: ['off'], |
There was a problem hiding this comment.
We need migrate on babel in next PR
|
npm audit works very bad 😞 |
package.json
Outdated
| "test": "jest", | ||
| "release": "standard-version" | ||
| "test:watch": "jest --watch", | ||
| "test:coverage": "jest --collectCoverageFrom='lib/**/*.js' --coverage", |
There was a problem hiding this comment.
I want to create jest.config.js like webpack-dev-server.
There was a problem hiding this comment.
I think we need do same in webpack-default and here
.github/CONTRIBUTING.md
Outdated
| @@ -0,0 +1,136 @@ | |||
| # Contributing in @webpack-contrib | |||
There was a problem hiding this comment.
- @webpack-contrib
+ webpack-dev-middlewareThere was a problem hiding this comment.
It is org, let's use webpack
| @@ -0,0 +1,136 @@ | |||
| # Contributing in @webpack-contrib | |||
|
|
|||
| We'd always love contributions to further improve the webpack / webpack-contrib ecosystem! | |||
There was a problem hiding this comment.
- webpack-contrib
+ webpack-dev-middlewareThere was a problem hiding this comment.
Here means thanks fro contributing and in webpack and in webpack ecosystem
|
@evilebottnawi Can you add renovate to this repository? |
|
@hiroppy What we should do here to enable this? |
alexander-akait
force-pushed
the
chore(default)-migrate
branch
from
0ae1816
to
6211696
Compare
| "test": "jest", | ||
| "release": "standard-version" | ||
| "test:coverage": "npm run test:only -- --coverage", | ||
| "test:watch": "npm run test:only --watch", |
There was a problem hiding this comment.
/cc @hiroppy watch should be without coverage, so better use test:only (we need fix it in webpack-dev-server)
There was a problem hiding this comment.
watch should be without coverage
hm... honestly, I want to be able to see coverage when running as test:watch.
|
/c @hiroppy fixed |
alexander-akait
force-pushed
the
chore(default)-migrate
branch
from
955982b
to
9c36a30
Compare
What kind of change does this PR introduce?
refactoring
Summary
Does this PR introduce a breaking change?
No
Other information
No