test: fix

webpack · Jan 23, 2024 · 555bddd · 555bddd
1 parent ba0a2fc
commit 555bddd
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 22 deletions.
diff --git a/test/e2e/__snapshots__/overlay.test.js.snap.webpack5 b/test/e2e/__snapshots__/overlay.test.js.snap.webpack5
@@ -2312,8 +2312,7 @@ exports[`overlay should show error for uncaught runtime error: overlay html 1`]
           "
         >
           Injected error at throwError (&lt;anonymous&gt;:2:15) at
-          &lt;anonymous&gt;:3:9 at addScriptContent
-          (__puppeteer_evaluation_script__:9:27)
+          &lt;anonymous&gt;:3:9
         </div>
       </div>
     </div>

diff --git a/test/e2e/__snapshots__/web-socket-server-url.test.js.snap.webpack5 b/test/e2e/__snapshots__/web-socket-server-url.test.js.snap.webpack5
@@ -33,7 +33,7 @@ exports[`web socket server URL should work and throw an error on invalid web soc
 
 exports[`web socket server URL should work and throw an error on invalid web socket URL ("sockjs"): page errors 1`] = `
 [
-  "SyntaxError: The URL's scheme must be either 'http:' or 'https:'. 'unknown:' is not allowed.",
+  "The URL's scheme must be either 'http:' or 'https:'. 'unknown:' is not allowed.",
 ]
 `;
 
@@ -45,7 +45,7 @@ exports[`web socket server URL should work and throw an error on invalid web soc
 
 exports[`web socket server URL should work and throw an error on invalid web socket URL ("ws"): page errors 1`] = `
 [
-  "DOMException: Failed to construct 'WebSocket': The URL's scheme must be either 'ws' or 'wss'. 'unknown' is not allowed.",
+  "Failed to construct 'WebSocket': The URL's scheme must be either 'ws' or 'wss'. 'unknown' is not allowed.",
 ]
 `;
 

diff --git a/test/e2e/on-listening.test.js b/test/e2e/on-listening.test.js
@@ -96,6 +96,8 @@ describe("onListening option", () => {
         pageErrors.push(error);
       })
       .on("request", (interceptedRequest) => {
+        if (interceptedRequest.isInterceptResolutionHandled()) return;
+
         interceptedRequest.continue({ method: "POST" });
       });
 

diff --git a/test/e2e/options-middleware.test.js b/test/e2e/options-middleware.test.js
@@ -58,23 +58,33 @@ describe("handle options-request correctly", () => {
     const prefixUrl = "http://127.0.0.1";
     const htmlUrl = `${prefixUrl}:${portForServer}/test.html`;
     const appUrl = `${prefixUrl}:${portForApp}`;
-    await page.goto(appUrl);
-    const responseStatus = [];
-    page.on("response", (res) => {
-      responseStatus.push(res.status());
-    });
-    await page.evaluate(
-      (url) =>
-        window.fetch(url, {
-          headers: {
-            "another-header": "1",
-          },
-        }),
-      htmlUrl,
-    );
-    await browser.close();
-    await server.stop();
-    await closeApp();
-    expect(responseStatus).toEqual([204, 200]);
+
+    try {
+      await page.goto(appUrl);
+
+      const responseStatus = [];
+
+      page.on("response", (res) => {
+        responseStatus.push(res.status());
+      });
+
+      await page.evaluate(
+        (url) =>
+          window.fetch(url, {
+            headers: {
+              "another-header": "1",
+            },
+          }),
+        htmlUrl,
+      );
+
+      expect(responseStatus).toEqual([200, 204, 200]);
+    } catch (error) {
+      throw error;
+    } finally {
+      await browser.close();
+      await server.stop();
+      await closeApp();
+    }
   });
 });