fix(client): set hot:false as a default

webpack · Apr 28, 2020 · 5bf0372 · 5bf0372
1 parent 0c74447
commit 5bf0372
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 2 deletions.
diff --git a/client-src/default/index.js b/client-src/default/index.js
@@ -15,7 +15,7 @@ const status = {
   currentHash: '',
 };
 const options = {
-  hot: true,
+  hot: false,
   hotReload: true,
   liveReload: false,
   initial: true,
@@ -36,6 +36,7 @@ if (typeof window !== 'undefined') {
 
 const onSocketMessage = {
   hot() {
+    options.hot = true;
     log.info('[WDS] Hot Module Replacement enabled.');
   },
   liveReload() {

diff --git a/test/client/__snapshots__/index.test.js.snap b/test/client/__snapshots__/index.test.js.snap
@@ -36,7 +36,7 @@ exports[`index should run onSocketMessage.ok 1`] = `"Ok"`;
 
 exports[`index should run onSocketMessage.ok 2`] = `
 Object {
-  "hot": true,
+  "hot": false,
   "hotReload": true,
   "initial": false,
   "liveReload": false,

diff --git a/test/e2e/TransportMode.test.js b/test/e2e/TransportMode.test.js
@@ -8,6 +8,7 @@ const {
   initConsoleDelay,
   awaitServerCloseDelay,
 } = require('../helpers/puppeteer-constants');
+const isWebpack5 = require('../helpers/isWebpack5');
 
 describe('transportMode client', () => {
   const modes = [
@@ -77,7 +78,16 @@ describe('transportMode client', () => {
                         res.splice(i, 1);
                       }
                     }
+
+                    // TODO: delete this code when getting rid of webpack5
+                    if (isWebpack5) {
+                      const swap = res[0];
+                      res[0] = res[1];
+                      res[1] = swap;
+                    }
+
                     expect(res).toMatchSnapshot();
+
                     done();
                   });
                 });

diff --git a/test/helpers/isWebpack5.js b/test/helpers/isWebpack5.js
@@ -0,0 +1,5 @@
+const webpack = require('webpack');
+
+export default () => {
+  return webpack.version[0] === '5';
+};