fix: improve warning message for open (#3191)

webpack · Apr 15, 2021 · d473fd9 · d473fd9
1 parent 384c4f5
commit d473fd9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/lib/utils/runOpen.js b/lib/utils/runOpen.js
@@ -73,7 +73,7 @@ function runOpen(uri, options, logger) {
                     .join(' ')}" arguments`
                 : ` in "${openTask.options.app}" app`
               : ''
-          }. If you are running in a headless environment, please do not use the "--open" flag or the "open" option.`
+          }. If you are running in a headless environment, please do not use the "open" option or related flags like "--open", "--open-target", and "--open-app".`
         );
       });
     })

diff --git a/test/server/open-option.test.js b/test/server/open-option.test.js
@@ -676,7 +676,7 @@ describe('"open" option', () => {
           wait: false,
         });
         expect(loggerWarnSpy).toHaveBeenCalledWith(
-          'Unable to open "http://localhost:8117/" page. If you are running in a headless environment, please do not use the "--open" flag or the "open" option.'
+          'Unable to open "http://localhost:8117/" page. If you are running in a headless environment, please do not use the "open" option or related flags like "--open", "--open-target", and "--open-app".'
         );
 
         loggerWarnSpy.mockRestore();
@@ -705,7 +705,7 @@ describe('"open" option', () => {
           wait: false,
         });
         expect(loggerWarnSpy).toHaveBeenCalledWith(
-          'Unable to open "http://localhost:8117/index.html" page. If you are running in a headless environment, please do not use the "--open" flag or the "open" option.'
+          'Unable to open "http://localhost:8117/index.html" page. If you are running in a headless environment, please do not use the "open" option or related flags like "--open", "--open-target", and "--open-app".'
         );
 
         loggerWarnSpy.mockRestore();
@@ -738,7 +738,7 @@ describe('"open" option', () => {
           wait: false,
         });
         expect(loggerWarnSpy).toHaveBeenCalledWith(
-          'Unable to open "http://localhost:8117/index.html" page in "google-chrome" app. If you are running in a headless environment, please do not use the "--open" flag or the "open" option.'
+          'Unable to open "http://localhost:8117/index.html" page in "google-chrome" app. If you are running in a headless environment, please do not use the "open" option or related flags like "--open", "--open-target", and "--open-app".'
         );
 
         loggerWarnSpy.mockRestore();
@@ -771,7 +771,7 @@ describe('"open" option', () => {
           wait: false,
         });
         expect(loggerWarnSpy).toHaveBeenCalledWith(
-          'Unable to open "http://localhost:8117/index.html" page in "google-chrome" app with "--incognito --new-window" arguments. If you are running in a headless environment, please do not use the "--open" flag or the "open" option.'
+          'Unable to open "http://localhost:8117/index.html" page in "google-chrome" app with "--incognito --new-window" arguments. If you are running in a headless environment, please do not use the "open" option or related flags like "--open", "--open-target", and "--open-app".'
         );
 
         loggerWarnSpy.mockRestore();
@@ -817,11 +817,11 @@ describe('"open" option', () => {
         );
         expect(loggerWarnSpy).toHaveBeenNthCalledWith(
           1,
-          'Unable to open "http://localhost:8117/first.html" page in "google-chrome" app with "--incognito --new-window" arguments. If you are running in a headless environment, please do not use the "--open" flag or the "open" option.'
+          'Unable to open "http://localhost:8117/first.html" page in "google-chrome" app with "--incognito --new-window" arguments. If you are running in a headless environment, please do not use the "open" option or related flags like "--open", "--open-target", and "--open-app".'
         );
         expect(loggerWarnSpy).toHaveBeenNthCalledWith(
           2,
-          'Unable to open "http://localhost:8117/second.html" page in "google-chrome" app with "--incognito --new-window" arguments. If you are running in a headless environment, please do not use the "--open" flag or the "open" option.'
+          'Unable to open "http://localhost:8117/second.html" page in "google-chrome" app with "--incognito --new-window" arguments. If you are running in a headless environment, please do not use the "open" option or related flags like "--open", "--open-target", and "--open-app".'
         );
 
         loggerWarnSpy.mockRestore();