Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade webpack-cli to v3.3x #1754

Merged

Conversation

EslamHiko
Copy link
Member

@EslamHiko EslamHiko commented Apr 3, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

NO

Motivation / Use-Case

make webpack-dev-server work with webpack-cli v3.3.x
fixes #1753

Breaking Changes

Changed the paths of convert-argv & config-yargs

Additional Info

NO

@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #1754 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1754   +/-   ##
=======================================
  Coverage   86.85%   86.85%           
=======================================
  Files           9        9           
  Lines         578      578           
  Branches      170      170           
=======================================
  Hits          502      502           
  Misses         63       63           
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 732e6c5...c8ae712. Read the comment docs.

package.json Outdated
"webpack": "^4.29.0",
"webpack-cli": "^3.2.1",
"webpack": "^4.29.6",
"webpack-cli": "github:webpack/webpack-cli#master",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is break webpack when developers don't have git

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need check version if less < 3.2 use old logic, if >= 3.3 use new logic otherwise it was big breaking change

@alexander-akait
Copy link
Member

@evenstensberg can we don't change location right now? Or just create file with import/export, it is really looks like breaking change and in theory can break not only webpack-dev-server

@EslamHiko
Copy link
Member Author

@evilebottnawi I got the idea to check if the new module with the new path exists or not and if it doesn't exist fall back to the original path so it can work with all versions v3.3.x and v3.2.x but I got that error 85:1 error Calls to require() should use string literals import/no-dynamic-require when committing
I can create a pull request but we will have to disable import/no-dynamic-require middleware

@alexander-akait
Copy link
Member

@EslamHiko just add // eslint-disable-next-line import/no-dynamic-require and add comment what in webpack-cli@3.3 change path to ...

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thanks!

@EslamHiko
Copy link
Member Author

@evilebottnawi you're Welcome 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to webpack-cli v.3.3.x
3 participants