Remove double brackets from the ws url when using raw IPv6 address #2951
Conversation
ilkkao
force-pushed
the
ilkkao/fix-double-braces-in-url
branch
from
0ddb128
to
1f2c674
Compare
| // Need to remove those as url.format blindly adds its own set of brackets | ||
| // if the host string contains colons. That would lead to non-working | ||
| // double brackets (e.g. [[::]]) host | ||
| host = host.replace(/^\[(.*)\]$/, '$1'); |
There was a problem hiding this comment.
Just interesting where we got extra brackets?
There was a problem hiding this comment.
In the problem case browser is navigated to http://[::]:8080/ Websocket URL is formed by taking the current location.hostname which includes the brackets. Then in the end native URL.format method at least on Chrome V8 adds a new set of braces even they already exists.
Feels that this is a V8 URL.format issue and gets someday fixed there based on nodejs/node#36654
ilkkao
force-pushed
the
ilkkao/fix-double-braces-in-url
branch
from
1f2c674
to
6f51d10
Compare
|
Tested manually as I wasn't able to quickly figure out how to add a new snapshot test.
|
ilkkao
changed the title
ilkkao
force-pushed
the
ilkkao/fix-double-braces-in-url
branch
from
6f51d10
to
edb079a
Compare
Codecov Report
@@ Coverage Diff @@
## master #2951 +/- ##
=======================================
Coverage 92.39% 92.39%
=======================================
Files 37 37
Lines 1262 1263 +1
Branches 326 327 +1
=======================================
+ Hits 1166 1167 +1
Misses 91 91
Partials 5 5
Continue to review full report at Codecov.
|
ilkkao
force-pushed
the
ilkkao/fix-double-braces-in-url
branch
from
edb079a
to
cca1c7a
Compare
|
Test failure btw doesn't seem to relate to my changes. |
Running into same issue on Ubuntu 20: This PR didn't seem to help and it still prints |
|
Time to merge and move to new release |
For Bugs and Features; did you add new tests?
TBD
Motivation / Use-Case
Fixes: #2943
Breaking Changes
Additional Info