Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow username and password in clientURL #3452

Merged
merged 8 commits into from Jun 18, 2021
Merged

Conversation

anshumanv
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

yes

Motivation / Use-Case

allow auth using username and password

Breaking Changes

no

Additional Info

@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #3452 (84c9519) into master (307f2e7) will decrease coverage by 0.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3452      +/-   ##
==========================================
- Coverage   94.13%   93.77%   -0.36%     
==========================================
  Files          33       33              
  Lines        1295     1301       +6     
  Branches      400      402       +2     
==========================================
+ Hits         1219     1220       +1     
- Misses         69       74       +5     
  Partials        7        7              
Impacted Files Coverage Δ
bin/cli-flags.js 100.00% <ø> (ø)
lib/utils/normalizeOptions.js 98.41% <ø> (ø)
lib/utils/DevServerPlugin.js 95.20% <100.00%> (-2.28%) ⬇️
lib/Server.js 94.84% <0.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 307f2e7...84c9519. Read the comment docs.

@alexander-akait
Copy link
Member

Will fix test in the next PR, we have problems with ports 😞

@alexander-akait alexander-akait merged commit a7225d5 into master Jun 18, 2021
@alexander-akait alexander-akait deleted the ws-up branch June 18, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants