Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show warnings in client overlay #789

Closed
SpaceK33z opened this issue Feb 15, 2017 · 2 comments
Closed

Show warnings in client overlay #789

SpaceK33z opened this issue Feb 15, 2017 · 2 comments

Comments

@SpaceK33z
Copy link
Member

Do you want to request a feature or report a bug?
Feature

What is the current behavior?

Compiler warnings will not be shown in the overlay and there is no option to turn that on.

What is the expected behavior?

Compiler warnings should be shown in the overlay, but not by default. As discussed with @bebraw, it could look like this:

overlay: {
  errors: true,
  warnings: true
}

overlay: true would be the same as overlay: { errors: true, warnings: false }.

If this is a feature request, what is motivation or use case for changing the behavior?

Some people like to fix the warnings first before seeing the result, now you need to look into the DevTools or the terminal to see those warnings. Also, CRA shows them too.
bebraw added a commit to bebraw/webpack-dev-server that referenced this issue Feb 16, 2017
@bebraw
feat - Allow overlay to be enabled for warnings
4a5ef22 
Now you can use

{
  overlay: {
    errors: true,
    warnings: true
  }
}

Closes webpack#789.
@bebraw bebraw mentioned this issue Feb 16, 2017
Merged
@bebraw
Copy link
Contributor

bebraw commented Feb 16, 2017

FYI, there's a PR at #790 for this now.

@SpaceK33z
Copy link
Member Author

@bebraw thanks for that :). I'll take a look soon.

bebraw added a commit to bebraw/webpack-dev-server that referenced this issue Feb 17, 2017
@bebraw
feat - Allow overlay to be enabled for warnings
a347cde 
Now you can use

{
  overlay: {
    errors: true,
    warnings: true
  }
}

Closes webpack#789.
bebraw added a commit to bebraw/webpack-dev-server that referenced this issue Feb 17, 2017
@bebraw
feat - Allow overlay to be enabled for warnings
3d8ccd5 
Now you can use

{
  overlay: {
    errors: true,
    warnings: true
  }
}

Closes webpack#789.
SpaceK33z pushed a commit that referenced this issue Feb 18, 2017
@bebraw @SpaceK33z
feat - Allow overlay to be enabled for warnings (#789) (#790)
4991704 
Now you can use

{
  overlay: {
    errors: true,
    warnings: true
  }
}

Closes #789.
@dcarral dcarral mentioned this issue Apr 22, 2017
Merged
dcarral added a commit to dcarral/webpack-dev-server that referenced this issue Apr 22, 2017
@dcarral
Do not show warnings @ overlay unless explicitly set
de3fbb0 
This change tweaks the feature behavior (implemented @ webpack#790),
so it matches the intended behavior (described @ webpack#789).

This PR would supersede survivejs/webpack-book#262.
@dcarral dcarral mentioned this issue Apr 22, 2017
Merged
shellscape pushed a commit that referenced this issue Jul 10, 2017
@dcarral @shellscape
Do not show warnings @ overlay unless explicitly set (#881)
e5b6202 
This change tweaks the feature behavior (implemented @ #790),
so it matches the intended behavior (described @ #789).

This PR would supersede survivejs/webpack-book#262.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bebraw @SpaceK33z