Add default filename when using through api #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be added to the documentation, but I think adding a default to the API is the wrong way. There should be a error message instead when in lazy mode but no |
|
Would you want to throw an error or just log it? |
|
Throw it. |
|
Rebased + updated. |
| @@ -14,6 +14,9 @@ var historyApiFallback = require("connect-history-api-fallback"); | |||
| function Server(compiler, options) { | |||
| // Default options | |||
| if(!options) options = {}; | |||
|
|
|||
| if (!options.filename) throw new Error("'filename' option must be set."); | |||
There was a problem hiding this comment.
It's only required in lazy mode. So check of options.lazy.
|
Updated! |
sokra
added a commit
that referenced
this pull request
Mar 9, 2015
Add default filename when using through api
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to set-up webpack-dev-server today via the API I ran into an issue that I was unable to ever load the bundle.
The issue was that the
filenameis only given a default when set via the CLI. I updated the wiki to note this requirement however it'd be good to have it built into the code by default.