Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add callback function as parameter of invalidate #1590

Closed

Conversation

Yangqin0607
Copy link

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

The invalidate function exported from webpack-dev-middleware can accept a paremeter. But this function in webpack-dev-server do not pass the paremeter to webpack-dev-middleware.

Breaking Changes

Additional Info

@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need tests

@codecov
Copy link

codecov bot commented Dec 6, 2018

Codecov Report

Merging #1590 into master will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1590   +/-   ##
=======================================
  Coverage   74.06%   74.06%           
=======================================
  Files          10       10           
  Lines         671      671           
=======================================
  Hits          497      497           
  Misses        174      174
Impacted Files Coverage Δ
lib/Server.js 81.42% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fadae5d...028b76f. Read the comment docs.

@alexander-akait
Copy link
Member

Also please accept CLA

@alexander-akait alexander-akait added this to the 3.4.0 milestone Apr 8, 2019
@hiroppy
Copy link
Member

hiroppy commented Apr 29, 2019

@Yangqin0607 Could you sign LCA and rebase?

@hiroppy
Copy link
Member

hiroppy commented May 30, 2019

This pr is inactive and the same pr was submitted #1900. So, I'll close.

@hiroppy hiroppy closed this May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants