Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Server): use class #1658

Merged
merged 1 commit into from
Feb 11, 2019
Merged

refactor(Server): use class #1658

merged 1 commit into from
Feb 11, 2019

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Feb 9, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

Cherry-pick from #1657 .

Breaking Changes

no

Additional Info

@hiroppy
Copy link
Member Author

hiroppy commented Feb 9, 2019

@evilebottnawi Could you restart Travis CI because I don't have an access right?

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but it is breaking change, we can do this only in next major release 😞 I am wrong

@codecov
Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #1658 into master will decrease coverage by 0.49%.
The diff coverage is 76.96%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1658     +/-   ##
=========================================
- Coverage   75.62%   75.12%   -0.5%     
=========================================
  Files          18       18             
  Lines         603      591     -12     
  Branches      171      171             
=========================================
- Hits          456      444     -12     
  Misses        113      113             
  Partials       34       34
Impacted Files Coverage Δ
lib/Server.js 78.49% <76.96%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ea376b...405dc73. Read the comment docs.

@alexander-akait alexander-akait merged commit f78a9a3 into webpack:master Feb 11, 2019
@hiroppy hiroppy deleted the feature/refactor-server.js branch February 11, 2019 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants