Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update #1671

Merged
merged 2 commits into from
Feb 19, 2019
Merged

chore(deps): update #1671

merged 2 commits into from
Feb 19, 2019

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

update deps

Breaking Changes

Should be no

Additional Info

No

/cc @hiroppy

What we need to do in next PRs:

  • Fix all ConcurrentCompilationError: You ran Webpack twice. Each instance only supports a single concurrent compilation at a time. errors in tests
  • Fix .skip test in Compress.test.js
  • Increase coverage and more tests

Can you take care?

}
// if (shouldSkipTestSuite()) {
// return;
// }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see on issue status with updated http-proxy-middleware

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evilebottnawi no 😄 #1672 we don't run npm test

@hiroppy
Copy link
Member

hiroppy commented Feb 19, 2019

wait for #1672

@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #1671 into master will decrease coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1671      +/-   ##
==========================================
- Coverage   75.45%   75.12%   -0.34%     
==========================================
  Files          19       17       -2     
  Lines         599      591       -8     
  Branches      173      172       -1     
==========================================
- Hits          452      444       -8     
  Misses        113      113              
  Partials       34       34
Impacted Files Coverage Δ
setupTest.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9fc9c7...1986ad6. Read the comment docs.

@alexander-akait
Copy link
Member Author

Problems with proxy solved 👍 Feel free to feedback

@alexander-akait alexander-akait merged commit f1246c7 into master Feb 19, 2019
@alexander-akait alexander-akait deleted the chore-update-deps branch February 19, 2019 14:55
@alexander-akait
Copy link
Member Author

/cc @hiroppy Can you help with #1671 (comment) (look bootom)? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants