-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update #1671
chore(deps): update #1671
Conversation
test/Proxy.test.js
Outdated
} | ||
// if (shouldSkipTestSuite()) { | ||
// return; | ||
// } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see on issue status with updated http-proxy-middleware
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems good with Node11 🎉 https://travis-ci.org/webpack/webpack-dev-server/jobs/495415842
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evilebottnawi no 😄 #1672 we don't run npm test
wait for #1672 |
Codecov Report
@@ Coverage Diff @@
## master #1671 +/- ##
==========================================
- Coverage 75.45% 75.12% -0.34%
==========================================
Files 19 17 -2
Lines 599 591 -8
Branches 173 172 -1
==========================================
- Hits 452 444 -8
Misses 113 113
Partials 34 34
Continue to review full report at Codecov.
|
bdc3555
to
13d2445
Compare
Problems with proxy solved 👍 Feel free to feedback |
/cc @hiroppy Can you help with #1671 (comment) (look bootom)? Thanks! |
For Bugs and Features; did you add new tests?
Motivation / Use-Case
update deps
Breaking Changes
Should be no
Additional Info
No
/cc @hiroppy
What we need to do in next PRs:
ConcurrentCompilationError: You ran Webpack twice. Each instance only supports a single concurrent compilation at a time.
errors in tests.skip
test inCompress.test.js
Can you take care?