Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(Util, Validation): close server each time test ends #1680

Merged
merged 1 commit into from
Feb 22, 2019
Merged

test(Util, Validation): close server each time test ends #1680

merged 1 commit into from
Feb 22, 2019

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Feb 21, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

no

Motivation / Use-Case

resolve ConcurrentCompilationError: You ran Webpack twice. Each instance only supports a single concurrent compilation at a time.

Breaking Changes

Additional Info

via #1673

@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #1680 into master will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1680      +/-   ##
==========================================
+ Coverage   76.17%   76.34%   +0.16%     
==========================================
  Files          17       17              
  Lines         596      596              
  Branches      173      173              
==========================================
+ Hits          454      455       +1     
+ Misses        108      107       -1     
  Partials       34       34
Impacted Files Coverage Δ
lib/Server.js 80.15% <0%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8d5c1e...49d65ca. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job!

@alexander-akait alexander-akait merged commit 66129a8 into webpack:master Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants