Pass mimeTypes option to webpack-dev-middleware

[dmohns]

• This is a bugfix
• This is a feature
• This is a code refactor
• This is a test update
• This is a docs update
• This is a metadata update

For Bugs and Features; did you add new tests?

Yes, tests for createConfig, a basic sanity check and test for changed mime type.

Motivation / Use-Case

webpack-dev-middleware exposes an option to set custom mime types via
passing a mimeType object, see
https://github.com/webpack/webpack-dev-middleware#mimetypes

This commit allows the user to set devServer.mimeType in
webpack.config.js to pass custom mimes types to
webpack-dev-middleware

Closes #1700

Breaking Changes

No.

Additional Info

As part of this change the documentation at https://webpack.js.org/guides/development/ needs to be updated as well. I couldn't yet figure out how this is done. And, whether or not the documentation has to be updated at the time (or can be updated later, once this PR is merged).

ToDo

• Add mimeType test
• Update documentation at https://webpack.js.org/guides/development/

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@05b8fb7). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1714   +/-   ##
=========================================
  Coverage          ?   83.76%           
=========================================
  Files             ?        8           
  Lines             ?      536           
  Branches          ?      161           
=========================================
  Hits              ?      449           
  Misses            ?       70           
  Partials          ?       17

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05b8fb7...f65705a. Read the comment docs.

[alexander-akait]

We create new issue in documentation page after merge, please ping me when we can review your PR, anyway code looks good, thanks!

[dmohns]

@evilebottnawi this PR can be reviewed. I updated the description to mirror the changes from the latest commits.

One question: In the test, I need to request main.js for the test to work, while it looks like other tests use bundle.js. Is this correct?

[alexander-akait]

One question: In the test, I need to request main.js for the test to work, while it looks like other tests use bundle.js. Is this correct?

Good question, we need check what is file created after run build

Anyway code looks good, let's investigate about main.js and bundle.js and we can merge

[dmohns]

It seems the default naming (when no output.filename is given) is not really documented anywhere. But this comment webpack/webpack#6543 (comment) suggests that the output filename will simply be the chunk name. While the chunk name again will be main because we are not using named (dict) entries but unnamed.

webpack-dev-server/test/fixtures/simple-config/webpack.config.js

Line 6 in fa17131

entry: './foo.js',

[alexander-akait]

@dmohns yep, let's look what file exists in output path for our test config (it should be simple)

[dmohns]

I am a little lost on this one. From the code, it simply looks like filename is not set (only path), see

webpack-dev-server/test/fixtures/simple-config/webpack.config.js

Lines 7 to 9 in 34a4a26

	output: {
	path: '/',
	},

[alexander-akait]

/cc @hiroppy can you see in test and help, don't have time right now

[alexander-akait]

@dmohns also please rebase on master

[alexander-akait]

/cc @hiroppy

[hiroppy]

lgtm, thanks!

[hiroppy]

@dmohns Could you submit a pr about this to https://github.com/webpack/webpack.js.org?