Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: compress option #1766

Merged
merged 2 commits into from
Apr 6, 2019
Merged

test: compress option #1766

merged 2 commits into from
Apr 6, 2019

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

yep

Motivation / Use-Case

Avoid skip test

Breaking Changes

No

Additional Info

/cc @hiroppy I think we should enable compress by default in next major for better DX, 99% developers set it to true

@alexander-akait
Copy link
Member Author

Added to https://github.com/webpack/webpack-dev-server/projects/1

@hiroppy
Copy link
Member

hiroppy commented Apr 5, 2019

@evilebottnawi I want to know how much the build speed, etc. will be affected if enabling compress. (if we make compress a default)

Copy link
Member

@hiroppy hiroppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@hiroppy hiroppy merged commit f61dfd4 into master Apr 6, 2019
@hiroppy hiroppy deleted the test-compress-option branch April 6, 2019 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants