Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): introduce open and remove opn #1865

Merged
merged 1 commit into from
Jun 5, 2019
Merged

chore(deps): introduce open and remove opn #1865

merged 1 commit into from
Jun 5, 2019

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented May 12, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

no

Motivation / Use-Case

opn was renamed to open.

Breaking Changes

no

Additional Info

@hiroppy
Copy link
Member Author

hiroppy commented May 12, 2019

This PR cannot be merged until we drop Node6.

Error: Failed: "/Users/vsts/agent/2.150.3/work/1/s/node_modules/open/index.js:11
const wslToWindowsPath = async path => {

@alexander-akait
Copy link
Member

Yes 👍

@hiroppy hiroppy changed the base branch from master to next June 5, 2019 18:44
Because opn was renamed to open.
@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #1865 into next will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #1865   +/-   ##
=======================================
  Coverage   92.35%   92.35%           
=======================================
  Files          28       28           
  Lines        1060     1060           
  Branches      322      322           
=======================================
  Hits          979      979           
  Misses         77       77           
  Partials        4        4
Impacted Files Coverage Δ
lib/utils/runOpen.js 70% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2323d45...1d43572. Read the comment docs.

@hiroppy hiroppy merged commit f2d4f13 into next Jun 5, 2019
@hiroppy hiroppy deleted the feature/opn branch June 5, 2019 20:47
hiroppy added a commit that referenced this pull request Jun 7, 2019
Because opn was renamed to open.
hiroppy added a commit that referenced this pull request Jun 10, 2019
Because opn was renamed to open.
hiroppy added a commit that referenced this pull request Jun 10, 2019
Because opn was renamed to open.
hiroppy added a commit that referenced this pull request Jun 15, 2019
Because opn was renamed to open.
hiroppy added a commit that referenced this pull request Jun 15, 2019
Because opn was renamed to open.
hiroppy added a commit that referenced this pull request Jun 15, 2019
Because opn was renamed to open.
hiroppy added a commit that referenced this pull request Jun 15, 2019
Because opn was renamed to open.
hiroppy added a commit that referenced this pull request Jun 24, 2019
Because opn was renamed to open.
hiroppy added a commit that referenced this pull request Jun 24, 2019
Because opn was renamed to open.
knagaitsev pushed a commit to knagaitsev/webpack-dev-server that referenced this pull request Jul 31, 2019
hiroppy added a commit that referenced this pull request Aug 1, 2019
Because opn was renamed to open.
hiroppy added a commit that referenced this pull request Aug 2, 2019
Because opn was renamed to open.
hiroppy added a commit that referenced this pull request Aug 5, 2019
Because opn was renamed to open.
hiroppy added a commit that referenced this pull request Sep 10, 2019
Because opn was renamed to open.
hiroppy added a commit that referenced this pull request Dec 12, 2019
Because opn was renamed to open.
hiroppy added a commit that referenced this pull request Dec 18, 2019
Because opn was renamed to open.
hiroppy added a commit that referenced this pull request Dec 19, 2019
Because opn was renamed to open.
hiroppy added a commit that referenced this pull request Dec 23, 2019
Because opn was renamed to open.
hiroppy added a commit that referenced this pull request Dec 24, 2019
Because opn was renamed to open.
alexander-akait pushed a commit that referenced this pull request Jan 29, 2020
alexander-akait pushed a commit that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants