Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: setupFeatures method #1891

Merged
merged 1 commit into from
May 16, 2019
Merged

refactor: setupFeatures method #1891

merged 1 commit into from
May 16, 2019

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

not require

Motivation / Use-Case

refactor

Breaking Changes

no

Additional Info

no

@alexander-akait alexander-akait added this to the 3.4.0 milestone May 16, 2019
@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #1891 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1891      +/-   ##
==========================================
- Coverage   88.34%   88.32%   -0.02%     
==========================================
  Files          14       14              
  Lines         815      814       -1     
  Branches      258      257       -1     
==========================================
- Hits          720      719       -1     
  Misses         82       82              
  Partials       13       13
Impacted Files Coverage Δ
lib/Server.js 86.3% <100%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df6a020...793aba9. Read the comment docs.

@hiroppy hiroppy merged commit 6020e21 into master May 16, 2019
@hiroppy hiroppy deleted the refactor-setupFeatures branch May 16, 2019 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants