Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(routes): stop checking for res.text #1952

Merged
merged 1 commit into from
Jun 3, 2019

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Jun 1, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

nope, updated

Motivation / Use-Case

I want to get rid of source code snapshots because a person who submits a pr might make a mistake. e.g. build using the old code and update the snapshot. But it is difficult to check at the review. (of course, CI will tell us)
I want to avoid testing being dependent on the built file of user's local. Also, clients are changing frequently.

Breaking Changes

no

Additional Info

@codecov
Copy link

codecov bot commented Jun 1, 2019

Codecov Report

Merging #1952 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1952   +/-   ##
======================================
  Coverage    91.8%   91.8%           
======================================
  Files          23      23           
  Lines         903     903           
  Branches      283     283           
======================================
  Hits          829     829           
  Misses         71      71           
  Partials        3       3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44a8cde...95fa58c. Read the comment docs.

@alexander-akait alexander-akait merged commit 9a1ad89 into master Jun 3, 2019
@alexander-akait alexander-akait deleted the feature/remove-text-from-routes branch June 3, 2019 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants