Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: delete temp directory #1958

Merged
merged 1 commit into from Jun 4, 2019
Merged

test: delete temp directory #1958

merged 1 commit into from Jun 4, 2019

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Jun 4, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

modify only

Motivation / Use-Case

Currently, main.css doesn't delete after running tests and it causes the errors of prettier.
In addition, we don't need temp directory. If you want it, you can use fs.mkdtemp.

Breaking Changes

no

Additional Info

Currently, main.css doesn't delete after running tests and it causes the errors of prettier.
@@ -40,11 +40,11 @@ describe('SockJSServer', () => {

const client = new SockJS('http://localhost:8080/sockjs-node');

client.onmessage = function(e) {
client.onmessage = (e) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning Unexpected unnamed function func-names

data.push(e.data);
};

client.onclose = function() {
client.onclose = () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning Unexpected unnamed function func-names

@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #1958 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1958   +/-   ##
=======================================
  Coverage   92.58%   92.58%           
=======================================
  Files          27       27           
  Lines         985      985           
  Branches      307      307           
=======================================
  Hits          912      912           
  Misses         70       70           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d346a53...66f0448. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexander-akait alexander-akait merged commit 27eb99c into master Jun 4, 2019
@alexander-akait alexander-akait deleted the feature/delete-temp branch June 4, 2019 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants