-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: don't support Node6 #1976
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One note
package.json
Outdated
@@ -11,7 +11,7 @@ | |||
"client" | |||
], | |||
"engines": { | |||
"node": ">= 6.11.5" | |||
"node": ">= 8.16.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 8.16.0
? We should support with 8.9.0
(low LTS verion)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
f70f5a0
to
a712446
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm nice
For Bugs and Features; did you add new tests?
no
Motivation / Use-Case
Next major version doesn't support Node6.
Breaking Changes
yes
Additional Info