Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: don't support Node6 #1976

Merged
merged 1 commit into from
Jun 5, 2019
Merged

chore: don't support Node6 #1976

merged 1 commit into from
Jun 5, 2019

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Jun 5, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

no

Motivation / Use-Case

Next major version doesn't support Node6.

Breaking Changes

yes

Additional Info

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note

package.json Outdated
@@ -11,7 +11,7 @@
"client"
],
"engines": {
"node": ">= 6.11.5"
"node": ">= 8.16.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 8.16.0? We should support with 8.9.0 (low LTS verion)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm nice

@hiroppy hiroppy merged commit 262cfe9 into next Jun 5, 2019
@hiroppy hiroppy deleted the feature/drop-node8 branch June 5, 2019 18:20
hiroppy added a commit that referenced this pull request Jun 7, 2019
hiroppy added a commit that referenced this pull request Jun 10, 2019
hiroppy added a commit that referenced this pull request Jun 15, 2019
hiroppy added a commit that referenced this pull request Jun 15, 2019
hiroppy added a commit that referenced this pull request Jun 15, 2019
hiroppy added a commit that referenced this pull request Jun 15, 2019
hiroppy added a commit that referenced this pull request Jun 24, 2019
hiroppy added a commit that referenced this pull request Jun 24, 2019
knagaitsev pushed a commit to knagaitsev/webpack-dev-server that referenced this pull request Jul 31, 2019
hiroppy added a commit that referenced this pull request Aug 1, 2019
hiroppy added a commit that referenced this pull request Aug 2, 2019
hiroppy added a commit that referenced this pull request Aug 5, 2019
hiroppy added a commit that referenced this pull request Sep 10, 2019
hiroppy added a commit that referenced this pull request Dec 12, 2019
hiroppy added a commit that referenced this pull request Dec 18, 2019
hiroppy added a commit that referenced this pull request Dec 19, 2019
hiroppy added a commit that referenced this pull request Dec 23, 2019
hiroppy added a commit that referenced this pull request Dec 24, 2019
alexander-akait pushed a commit that referenced this pull request Jan 29, 2020
alexander-akait pushed a commit that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants