-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade selfsigned dependency for node-forge security patch #2740
chore: upgrade selfsigned dependency for node-forge security patch #2740
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2740 +/- ##
==========================================
- Coverage 93.77% 93.54% -0.23%
==========================================
Files 34 34
Lines 1333 1333
Branches 381 381
==========================================
- Hits 1250 1247 -3
- Misses 81 84 +3
Partials 2 2
Continue to review full report at Codecov.
|
@katelovescode Thank you so much for your first time contribution here!! 😍 I re-ran tests because it looked flakey but once we get tests passing I'll ask @evilebottnawi double check w/ me if they fail again. Otherwise. LGTM! |
Could someone look into the automation failures and get the PR merged? It would be super helpful. Thank you. |
@TheLarkInn I'm investigating the test suites that failed; the linting failed because of my second commit message, which I'll fix when I squash and repush. The Node 8 instances all seem to be running for a very long time and throwing lots of These tests all pass on my local: OSX 10.15.7, Node 12.14.1 Test failures on
Error/syntax error on Linux, Mac and Windows Node 6 (there are cascading failures about ports not being available, etc., seems like Node 6 might have some compatibility issues with the code as-is):
Test failures on Windows Node 14:
If you've got configuration for those Azure pipelines documented somewhere public, I wouldn't mind looking into it a little more. |
We are preparing v4 with updated deps, anyway you can update your deps locally, no need to do release |
For Bugs and Features; did you add new tests?
N/A
Motivation / Use-Case
Security vulnerability in a dependency of selfsigned; they bumped a version to patch it, so this updates webpack-dev-server's dependency to the patched version.
Breaking Changes
N/A
Additional Info
N/A