Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make client overlay default to be true #3103

Closed
wants to merge 6 commits into from

Conversation

rishabh3112
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes, will add

Motivation / Use-Case

suggested by @alexander-akait

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #3103 (88b8c65) into master (45b698d) will decrease coverage by 1.53%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3103      +/-   ##
==========================================
- Coverage   91.84%   90.31%   -1.54%     
==========================================
  Files          37       37              
  Lines        1288     1290       +2     
  Branches      346      347       +1     
==========================================
- Hits         1183     1165      -18     
- Misses         99      116      +17     
- Partials        6        9       +3     
Impacted Files Coverage Δ
lib/utils/normalizeOptions.js 100.00% <100.00%> (ø)
lib/utils/DevServerPlugin.js 73.97% <0.00%> (-26.03%) ⬇️
lib/Server.js 93.08% <0.00%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45b698d...88b8c65. Read the comment docs.

@snitin315
Copy link
Member

Let's fix CI.

@rishabh3112
Copy link
Member Author

rishabh3112 commented Mar 24, 2021

Let's fix CI.

Any suggestions? I updated snapshots but it is now regressing on hash values, which will be different every time.

@snitin315
Copy link
Member

snitin315 commented Mar 24, 2021

You can replace hash in a snapshot with <hash> or XXXX, like we do for ports

normalizedStderr = normalizedStderr.replace(/:[0-9]+\//g, ':<port>/');

@rishabh3112
Copy link
Member Author

Okay, I will try

@snitin315 snitin315 mentioned this pull request Mar 25, 2021
6 tasks
@rishabh3112 rishabh3112 deleted the chore/overlay-default branch March 26, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants