-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make client overlay default to be true #3103
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3103 +/- ##
==========================================
- Coverage 91.84% 90.31% -1.54%
==========================================
Files 37 37
Lines 1288 1290 +2
Branches 346 347 +1
==========================================
- Hits 1183 1165 -18
- Misses 99 116 +17
- Partials 6 9 +3
Continue to review full report at Codecov.
|
Let's fix CI. |
Any suggestions? I updated snapshots but it is now regressing on hash values, which will be different every time. |
You can replace hash in a snapshot with
|
Okay, I will try |
For Bugs and Features; did you add new tests?
Yes, will add
Motivation / Use-Case
suggested by @alexander-akait
Breaking Changes
No
Additional Info
No