Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect the client.logging option for HMR logging #3159

Merged
merged 10 commits into from
Apr 9, 2021

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Apr 7, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

fixes #2946 fixes #2932

Motivation / Use-Case

Allow to disable extra logging from webpack

Breaking Changes

No

Additional Info

  • I keep logging api, so other modules can change it in runtime
  • fix broken currentScript parsing
  • support new URL() and Node.js legacy format
  • refactor
  • more tests

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #3159 (1388d5e) into master (2c92d3c) will decrease coverage by 0.05%.
The diff coverage is 91.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3159      +/-   ##
==========================================
- Coverage   94.99%   94.93%   -0.06%     
==========================================
  Files          37       38       +1     
  Lines        1218     1245      +27     
  Branches      338      346       +8     
==========================================
+ Hits         1157     1182      +25     
- Misses         55       57       +2     
  Partials        6        6              
Impacted Files Coverage Δ
client-src/utils/reloadApp.js 86.95% <ø> (ø)
lib/Server.js 94.14% <ø> (-0.03%) ⬇️
lib/utils/createDomain.js 100.00% <ø> (ø)
client-src/index.js 91.42% <68.18%> (-0.97%) ⬇️
client-src/clients/SockJSClient.js 100.00% <100.00%> (ø)
client-src/clients/WebsocketClient.js 88.23% <100.00%> (-0.66%) ⬇️
client-src/utils/createSocketURL.js 100.00% <100.00%> (ø)
client-src/utils/getCurrentScriptSource.js 100.00% <100.00%> (ø)
client-src/utils/parseURL.js 100.00% <100.00%> (ø)
lib/utils/DevServerPlugin.js 97.36% <100.00%> (+0.10%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c92d3c...1388d5e. Read the comment docs.

@alexander-akait
Copy link
Member Author

Will finish tomorrow, need improve client for file protocol and test https with localhost

@snitin315
Copy link
Member

@alexander-akait what is still in TODO here?

@alexander-akait
Copy link
Member Author

WIP on tests, broken only on Node.js 10 due bug in url module implementation

@snitin315
Copy link
Member

Node 10 is about to reach its end of life 😞

@alexander-akait
Copy link
Member Author

Yep, but I think webpack-dev-server v4 will have short time, we should refactor it to plugin, I'll show you how to do it

@alexander-akait
Copy link
Member Author

We will improve coverage after refactor public/client.sock* properties

@alexander-akait alexander-akait merged commit 6f3c6ba into master Apr 9, 2021
@alexander-akait alexander-akait deleted the issue-2932 branch April 9, 2021 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot mute [HMR] Waiting for update signal from WDS... in browser console
2 participants