test: add e2e tests for built in routes #3669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
requested review from
alexander-akait,
anshumanv,
hiroppy and
knagaitsev
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3669 +/- ##
=======================================
Coverage 93.67% 93.67%
=======================================
Files 15 15
Lines 1312 1312
Branches 451 451
=======================================
Hits 1229 1229
Misses 76 76
Partials 7 7 Continue to review full report at Codecov.
|
| afterEach(async () => { | ||
| await browser.close(); | ||
| await server.stop(); | ||
| }); |
There was a problem hiding this comment.
This is the right way, we should rewrite all our test on this, it is better for debug and testing, it was in my roadmap, so feel free to do it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Motivation / Use-Case
add e2e tests for built in routes.
Breaking Changes
No
Additional Info
No